Fix lib install with git url #1143
Merged
+319
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
requested review from
cmaglie,
alranel,
ubidefeo,
per1234 and
rsora
silvanocerza
force-pushed
the
scerza/lib-install-git
branch
from
63de446 to
4a657f4
Compare
per1234
reviewed
Jan 19, 2021
silvanocerza
force-pushed
the
scerza/lib-install-git
branch
from
89ca9f3 to
ae405a0
Compare
per1234
reviewed
Jan 20, 2021
per1234
requested changes
Jan 20, 2021
per1234
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixes a bug with an existing command.
Calling
arduino-cli lib install --git-url .is executed successfully but the library is installed in the wrong folder, to be precise it's installed directly inside the<sketch_book_dir>/librariesfolder, so the whole content of the library ends there.Calling
arduino-cli lib install --git-url .now correctly deduces the library name from the given path and installs it in the<sketch_book_dir>/libraries/<lib_name>folder.Nope.
Fixes #1120
See how to contribute